-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Make CI not update the lock file #2152
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -110,6 +110,11 @@ get_vendor_deps: | |
@rm -rf .vendor-new | ||
@dep ensure -v | ||
|
||
get_vendor_deps_ci: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Almost an identical target to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure. I think makefiles tend to be super hard to read, so I prefer not using flags for the simple things in the main commands. I don't feel strongly about this, so if you'd prefer flags id be happy to change it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nor do I -- you can keep as is. |
||
@echo "--> Running dep ensure" | ||
@rm -rf .vendor-new | ||
@dep ensure -v -vendor-only | ||
|
||
draw_deps: | ||
@# requires brew install graphviz or apt-get install graphviz | ||
go get github.com/RobotsAndPencils/goviz | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember we had something like that in Tendermint, but switched to
make get_vendor_deps
. Does this mean we should do the same change in Tendermint?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably. We made that change before we ensured the lock file is correct, but now that we do, we can go back to how we used to do it Tendermint!