refactor(x/auth): Decouple store from auth module #21405
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return c | ||
| } | ||
|
|
||
| // WithNewGasMeter returns a Context with a newly created transaction GasMeter. | ||
| func (c Context) WithNewGasMeter(gaslimit storetypes.Gas) Context { | ||
| c.gasMeter = storetypes.NewGasMeter(gaslimit) | ||
| return c |
There was a problem hiding this comment.
Change potentially affects state.
Call sequence:
(github.com/cosmos/cosmos-sdk/types.Context).WithBlockGasMeter (types/context.go:224)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).PrepareProposal (types/context.go:393)
| gm: gm, | ||
| } | ||
| } | ||
|
|
||
| func (gm SDKGasMeter) GasConsumed() storetypes.Gas { |
There was a problem hiding this comment.
@tac0turtle this is where i think we need a consumed API
| @@ -220,6 +220,18 @@ func (c Context) WithGasMeter(meter storetypes.GasMeter) Context { | |||
| return c | |||
| } | |||
|
|
|||
| // WithNewGasMeter returns a Context with a newly created transaction GasMeter. | |||
There was a problem hiding this comment.
imho we shouldn't add anything to sdk.Context. We want to move away from it.
| ) | ||
|
|
||
| // Wrapper errors for store/v1 ErrorOutOfGas, ErrorNegativeGasConsumed and ErrorGasOverflow so that | ||
| // modules don't have to import storev1 directly. |
There was a problem hiding this comment.
I'd rather have module import store tan the SDK tbh (my t.wo cents)
Can we avoid adding stuff in the SDK?
There was a problem hiding this comment.
hmmmm if we use stf gas implementation then we can avoid import storetypes ErrorOutOfGas all together (so i dont have to wrapped it here). But then we need to add a wrapper for the legacy sdkCtx gas meter, the problem is that the wrapper is in runtime
|
closing this since auth doesnt have it own go mod anymore |
Description
ref: #21183
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...