transient store missed to implement store type interface

[HaoyangLiu]

Currently transient store doesn't implement store type interface. As a result, when calculating commitStores, the transient store will also be included, which is unexpected.

func commitStores(version int64, storeMap map[StoreKey]CommitStore) commitInfo {
	storeInfos := make([]storeInfo, 0, len(storeMap))

	for key, store := range storeMap {
		// Commit
		commitID := store.Commit()

		if store.GetStoreType() == sdk.StoreTypeTransient {
			continue
		}

		// Record CommitID
		si := storeInfo{}
		si.Name = key.Name()
		si.Core.CommitID = commitID
		// si.Core.StoreType = store.GetStoreType()
		storeInfos = append(storeInfos, si)
	}

	ci := commitInfo{
		Version:    version,
		StoreInfos: storeInfos,
	}
	return ci
}

Now, we have two params store. One is IAVL store and another one is transient.

		keyParams:        sdk.NewKVStoreKey("params"),
		tkeyParams:       sdk.NewTransientStoreKey("params"),

They have the same name. And the second one should not be included in commitInfo. However, due to the bugs I mentioned above, both the two store are included in commitInfo.
@jaekwon @adrianbrink

[alexanderbez]

Reference: #2013

[HaoyangLiu]

https://github.com/cosmos/cosmos-sdk/pull/2013/files
The above PR still doesn't add store type interface implementation, though it renamed the transient parameter store name.

[alexanderbez]

@HaoyangLiu correct, I'm just adding it as a reference as that was mentioned in the description of your PR ;-)

[rigelrozanski]

Minor failing in the linter (which needs to be fixed before merge) but other than that it looks good!

[codecov]

Codecov Report

Merging #2037 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #2037      +/-   ##
===========================================
- Coverage    64.86%   64.84%   -0.03%     
===========================================
  Files          115      115              
  Lines         6863     6864       +1     
===========================================
- Hits          4452     4451       -1     
- Misses        2127     2129       +2     
  Partials       284      284

[HaoyangLiu]

I have fixed the issue you mentioned @rigelrozanski

[cwgoes]

Try merging develop, might fix CI.

[rigelrozanski]

looks like test_cover failing due to non-determinism, should merge in develop to see if fixes

[ValarDragon]

Re ran, and tests now pass. This should be good to merge

[ValarDragon]

Thanks for spotting this!