Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove defer in loop #20223

Merged
merged 29 commits into from
May 29, 2024
Merged

refactor: remove defer in loop #20223

merged 29 commits into from
May 29, 2024

Commits on Apr 30, 2024

  1. refactor defer in loop, and add error handling for Close function

    @tuantran1702
    tuantran1702 committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    248ad76 View commit details
    Browse the repository at this point in the history

  2. Update store/storage/storage_test_suite.go 

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    @tuantran1702 @coderabbitai
    tuantran1702 and coderabbitai[bot] authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    306cf5b View commit details
    Browse the repository at this point in the history

  3. Update x/group/keeper/invariants.go 

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    @tuantran1702 @coderabbitai
    tuantran1702 and coderabbitai[bot] authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    7b0116e View commit details
    Browse the repository at this point in the history

  4. Update store/commitment/store.go 

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    @tuantran1702 @coderabbitai
    tuantran1702 and coderabbitai[bot] authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e45b71f View commit details
    Browse the repository at this point in the history

  5. Update store/commitment/store.go 

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    @tuantran1702 @coderabbitai
    tuantran1702 and coderabbitai[bot] authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    023247e View commit details
    Browse the repository at this point in the history

  6. Update store/migration/manager.go 

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    @tuantran1702 @coderabbitai
    tuantran1702 and coderabbitai[bot] authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    93c36dc View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. refactor to use anonymous closure

    @tuantran1702
    tuantran1702 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    b0c99b4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refactor-defer' of github.com:notional-labs/cosmos-sdk … 

    …into refactor-defer
    @tuantran1702
    tuantran1702 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    badd9c5 View commit details
    Browse the repository at this point in the history

  3. linting

    @tuantran1702
    tuantran1702 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9995356 View commit details
    Browse the repository at this point in the history

  4. rollback importer defer, bring pw.Close() to closure

    @tuantran1702
    tuantran1702 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    b6c8dbe View commit details
    Browse the repository at this point in the history

  5. remove incorrect Close()

    @tuantran1702
    tuantran1702 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    097384b View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. refactor

    @tuantran1702
    tuantran1702 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    e7b1a17 View commit details
    Browse the repository at this point in the history

  2. fix redundant err check

    @tuantran1702
    tuantran1702 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b6a63be View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. refactor defer in loop, and add error handling for Close function

    @tuantran1702
    tuantran1702 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    95fc4a7 View commit details
    Browse the repository at this point in the history

  2. refactor to use anonymous closure

    @tuantran1702
    tuantran1702 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    869ec3e View commit details
    Browse the repository at this point in the history

  3. Update store/storage/storage_test_suite.go 

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    @tuantran1702 @coderabbitai
    tuantran1702 and coderabbitai[bot] committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d819ddd View commit details
    Browse the repository at this point in the history

  4. Update store/commitment/store.go 

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    @tuantran1702 @coderabbitai
    tuantran1702 and coderabbitai[bot] committed May 9, 2024
    Configuration menu
    Copy the full SHA
    4543e67 View commit details
    Browse the repository at this point in the history

  5. Update store/commitment/store.go 

    Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    @tuantran1702 @coderabbitai
    tuantran1702 and coderabbitai[bot] committed May 9, 2024
    Configuration menu
    Copy the full SHA
    fce217a View commit details
    Browse the repository at this point in the history

  6. linting

    @tuantran1702
    tuantran1702 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    fbaef03 View commit details
    Browse the repository at this point in the history

  7. rollback importer defer, bring pw.Close() to closure

    @tuantran1702
    tuantran1702 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    953cfac View commit details
    Browse the repository at this point in the history

  8. remove incorrect Close()

    @tuantran1702
    tuantran1702 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    879999d View commit details
    Browse the repository at this point in the history

  9. refactor

    @tuantran1702
    tuantran1702 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    e9df29b View commit details
    Browse the repository at this point in the history

  10. fix redundant err check

    @tuantran1702
    tuantran1702 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    8701127 View commit details
    Browse the repository at this point in the history

  11. add missing import

    @tuantran1702
    tuantran1702 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    0415482 View commit details
    Browse the repository at this point in the history

  12. add err handling

    @tuantran1702
    tuantran1702 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    a737df0 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2024

  1. Merge branch 'main' into refactor-defer

    @tuantran1702
    tuantran1702 authored May 11, 2024
    Configuration menu
    Copy the full SHA
    2f0ac3f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refactor-defer' of github.com:notional-labs/cosmos-sdk … 

    …into refactor-defer
    @tuantran1702
    tuantran1702 committed May 11, 2024
    Configuration menu
    Copy the full SHA
    5bc9597 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Merge branch 'main' into refactor-defer

    @tuantran1702
    tuantran1702 authored May 17, 2024
    Configuration menu
    Copy the full SHA
    076a43f View commit details
    Browse the repository at this point in the history

  2. lint errorf

    @tuantran1702
    tuantran1702 committed May 17, 2024
    Configuration menu
    Copy the full SHA
    101706b View commit details
    Browse the repository at this point in the history