refactor(x/gov): reduce "if block" indentation

[lilasxie]

Summary

• Addition of reducing the indentation of "if block" for module x/gov
• Addition of return earlier when checked error is nil in errors.IsOf

[coderabbitai]

Walkthrough

The recent updates involve refining error handling across various components. The IsOf function now precludes nil error checks, and corresponding tests have been added. In the governance module, the EndBlocker, Proposal, and Vote functions, as well as the SubmitProposal logic, have been restructured for better clarity and error management. These changes contribute to more robust and understandable code.

Changes

Files	Change Summary
errors/errors.go, errors/errors_test.go, errors/CHANGELOG.md	Modified IsOf function to include nil error check, added new require.False assertions in tests.
x/gov/abci.go	Modified error handling in EndBlocker function.
x/gov/keeper/grpc_query.go, x/gov/keeper/proposal.go	Modified error handling in Proposal and Vote functions, refactored SubmitProposal for improved code quality.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your comments unless it is explicitly tagged.

• You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
  • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[alexanderbez]

utACK

[lilasxie]

@julienrbrt Hi sir, addressed suggestion changes

[julienrbrt]

lgtm!

[tac0turtle]

thanks for the pr