fix(x/auth): duplicate vesting subcommands of <appd> tx --help

[Halimao]

Description

Running <appd> tx --help will show duplicate vesting subcommand and missing <appd> tx auth update-params-proposal subcommand

This is due to a duplicate implementation for type HasCustomTxCommand interface in x/auth/module.go AppModuleBasic and x/auth/vesting/module.go AppModuleBasic, by returning the same x/auth/vesting/cli/tx.go GetTxCmd().

As x/auth/autocli.go has initialized the TX field, we can simply return nil for x/auth/module.go AppModuleBasic GetTxCmd()

Note

This bug couldn't be reproduced all the time, but very high frequence

Before fix:

After fix:

[coderabbitai]

Walkthrough

The changes in the x/auth package of the Cosmos SDK involve the removal of certain dependencies and a shift in the command handling strategy. An import related to cryptographic functionality (secp256r1) has been removed, suggesting a deprecation or relocation. Additionally, vesting-related CLI dependencies have been eliminated, and the GetTxCmd function has been altered to return nil, indicating a possible restructuring or simplification of transaction command registration.

Changes

Files	Change Summary
x/auth/autocli.go, x/auth/module.go	Removed import: cosmossdk.io/api/cosmos/crypto/secp256r1; Removed import: cosmossdk.io/x/auth/vesting/client/cli; Altered GetTxCmd function to return nil
CHANGELOG.md	Bug fixes related to subcommands, error handling, gas fee computation, and termination behavior in the x/auth module.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can reply to a review comment made by CodeRabbit.
• You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
• You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[julienrbrt]

lgtm, just one comment

[julienrbrt]

Thank you!

[atheeshp]

lgtm