Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store/v2): Add Pruning Tests & Fix SQLite & PebbleDB Pruning #18459

Merged
merged 27 commits into from
Nov 17, 2023
Merged

feat(store/v2): Add Pruning Tests & Fix SQLite & PebbleDB Pruning #18459

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
ff31990
updates
alexanderbez Nov 13, 2023
b93cbcf
updates
alexanderbez Nov 14, 2023
20a687d
updates
alexanderbez Nov 14, 2023
a4e2e6e
updates
alexanderbez Nov 14, 2023
18983d5
updates
alexanderbez Nov 14, 2023
1120a92
updates
alexanderbez Nov 14, 2023
18c5e20
Merge branch 'main' into bez/fix-sqlite-ss-prune
alexanderbez Nov 14, 2023
1836016
updates
alexanderbez Nov 14, 2023
e8296c0
Merge branch 'bez/fix-sqlite-ss-prune' of github.com:cosmos/cosmos-sd…
alexanderbez Nov 14, 2023
168d0c4
Merge branch 'main' into bez/fix-sqlite-ss-prune
alexanderbez Nov 15, 2023
7d7ac92
updates
alexanderbez Nov 15, 2023
224998f
Merge branch 'bez/fix-sqlite-ss-prune' of github.com:cosmos/cosmos-sd…
alexanderbez Nov 15, 2023
cd14557
updates
alexanderbez Nov 15, 2023
b85d911
updates
alexanderbez Nov 16, 2023
8fc7e93
updates
alexanderbez Nov 16, 2023
49c6c6c
updates
alexanderbez Nov 16, 2023
3a11bb9
updates
alexanderbez Nov 16, 2023
08113b4
updates
alexanderbez Nov 16, 2023
035fafd
updates
alexanderbez Nov 16, 2023
ba3cab5
Merge branch 'main' into bez/fix-sqlite-ss-prune
alexanderbez Nov 16, 2023
930dbd4
Merge branch 'main' into bez/fix-sqlite-ss-prune
alexanderbez Nov 16, 2023
b65a4c1
updates
alexanderbez Nov 16, 2023
cb6aa04
Merge branch 'bez/fix-sqlite-ss-prune' of github.com:cosmos/cosmos-sd…
alexanderbez Nov 16, 2023
582b11a
Merge branch 'main' into bez/fix-sqlite-ss-prune
alexanderbez Nov 17, 2023
c44fd82
updates
alexanderbez Nov 17, 2023
94bc2bb
updates
alexanderbez Nov 17, 2023
d903a1e
updates
alexanderbez Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updates
  • Loading branch information
@alexanderbez
alexanderbez committed Nov 17, 2023
commit c44fd82995dccdd39c3a809645a77eb10eb7ad9f
1 change: 1 addition & 0 deletions store/storage/pebbledb/db_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ func TestStorageTestSuite(t *testing.T) {
NewDB: func(dir string) (store.VersionedDatabase, error) {
db, err := New(dir)
if err == nil && db != nil {
// we set sync=false just to speed up CI tests
db.SetSync(false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in most environments this would be true, is there a reason to setting this to false for testing?

Copy link
Contributor Author

@alexanderbez alexanderbez Nov 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just to make the unit tests faster. Not a strong reason, but it helps speed up CI testing time. (11.994s vs 1.214s)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!! could you add a short comment saying this. Would help for future readers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha

}

Expand Down