-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: secp256k1 public key constant time #18026
Merged
Merged
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
c32ca65
added bench test for ed25519 key
bizk d54017c
added multisig test
bizk ffc39eb
added hashihg for basic ADR28 address on ed25519
bizk 1770ef3
ran lint fix
bizk 546dd4e
merge with master
bizk 5f20b8c
Refactor tests
bizk d057344
merge
bizk 71d6a6d
Merge branch 'main' of github.com:Zondax/cosmos-sdk into zondax/featu…
bizk f46939e
empty commit to re run actions
bizk c5872a0
empty commit to re run actions
bizk b148bd3
Merge branch 'main' of github.com:Zondax/cosmos-sdk into zondax/featu…
bizk e6d38b7
Merge branch 'main' of github.com:Zondax/cosmos-sdk into …
bizk 0655ad1
added go constant time secp256k1
bizk 09ce545
added constant time pub key implementation and tests
bizk 2af7ad3
Merge branch 'main' of github.com:Zondax/cosmos-sdk into zondax/featu…
bizk 1b18936
reverted changes and deleted optimization to make code fully constant
bizk f0e1c06
removed tidy code
bizk ae93077
Added changelog.md
bizk 4ebca65
cleanup
bizk b6a0494
cleanup
bizk e5f98c5
go lint fix
bizk 0586436
gofumpt files
bizk 6416425
added fix on deprecated package
bizk 8898092
suggestion by linter
bizk 70c604c
ran gci
bizk 5e96e6b
gci fix
bizk 6a70994
returned file back to how it was
bizk d1fb6d0
Merge branch 'main' into feature/secp256k1constant
bizk d6519f4
Merge branch 'main' into feature/secp256k1constant
bizk c89049c
Merge branch 'main' into feature/secp256k1constant
bizk 9b2fb97
switched secp point generation library
bizk 8f2685c
Merge branch 'feature/secp256k1constant' of github.com:Zondax/cosmos-…
bizk f3462b9
switched secp priv key generation to constant time implementation and…
bizk b18542c
Merge branch 'main' into feature/secp256k1constant
bizk cc501e3
added missing go.mod files
bizk 6b3c859
Merge branch 'main' into feature/secp256k1constant
bizk 68154f5
solved issue with go.mod files
bizk 54318a5
fixed small tests
bizk c25aa08
Merge branch 'feature/secp256k1constant' of github.com:Zondax/cosmos-…
bizk a8508ed
fixed hd and ledger tests, also added missing go.mod
bizk 16883d1
fixed add_key test
bizk 465f1e6
lint-fix
bizk 7389cd2
fixed issues
bizk 397c526
gcied add.go file
bizk f8be857
Merge branch 'main' into feature/secp256k1constant
bizk 4eb2fbf
gcied modified file
bizk 87e1ecf
Merge branch 'feature/secp256k1constant' of github.com:Zondax/cosmos-…
bizk 84db0b4
lint fix
bizk 1485810
Merge branch 'main' into feature/secp256k1constant
bizk 4cb92c4
Merge branch 'main' into feature/secp256k1constant
bizk 9f15cfd
ran go mod script
bizk 8ea5da5
rollback internal secp key generation on test
bizk b6e6cbe
Merge branch 'main' into feature/secp256k1constant
bizk ef99726
lint fix
bizk 01c79d5
Merge branch 'main' into feature/secp256k1constant
bizk c2d5fa9
Merge branch 'main' into feature/secp256k1constant
bizk 10b8a8a
Merge branch 'main' into feature/secp256k1constant
bizk 0b29d5e
fixed tests
bizk 8bc73ee
merge
bizk 9b04f9e
Merge branch 'main' into feature/secp256k1constant
bizk eeb4fc7
fixed changelog
bizk 7989412
Merge branch 'main' into feature/secp256k1constant
bizk 2217d1b
Merge branch 'main' into feature/secp256k1constant
bizk 0c101fa
removed unused import
bizk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fixed add_key test
- Loading branch information
commit 16883d1fb76e30c3d37f12d21557c17997440810
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
secp256k1.PubKey{}
struct should be initialized with a key of the correct size to prevent potential issues.Committable suggestion