Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gov): fail proposal when implementation not found #17873

Merged
merged 8 commits into from
Sep 26, 2023
Merged

fix(gov): fail proposal when implementation not found #17873

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2995eba
fix(gov): do not panic when proposal implementation not found
julienrbrt Sep 25, 2023
d376e6a
updates
julienrbrt Sep 25, 2023
9257e67
finish tests
julienrbrt Sep 25, 2023
b7cb1d0
Merge branch 'main' into julien/fix-gov
julienrbrt Sep 25, 2023
cc4ce8d
changelog
julienrbrt Sep 25, 2023
e34ff2b
updates
julienrbrt Sep 25, 2023
22534af
feedback
julienrbrt Sep 26, 2023
fed2a8b
Merge branch 'main' into julien/fix-gov
julienrbrt Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feedback
  • Loading branch information
@julienrbrt
julienrbrt committed Sep 26, 2023
commit 22534af3784212cb0f5227d49bab5557a6933ea8
16 changes: 11 additions & 5 deletions x/gov/abci.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ func EndBlocker(ctx sdk.Context, keeper *keeper.Keeper) error {
proposal, err := keeper.Proposals.Get(ctx, key.K2())
if err != nil {
// if the proposal has an encoding error, this means it cannot be processed by x/gov
// this could be to some types missing their registration
// this could be due to some types missing their registration
// instead of returning an error (i.e, halting the chain), we fail the proposal
if errors.Is(err, collections.ErrEncoding) {
proposal.Id = key.K2()
if err := failUnsupportedProposal(logger, ctx, keeper, proposal, err.Error()); err != nil {
if err := failUnsupportedProposal(logger, ctx, keeper, proposal, err.Error(), false); err != nil {
return false, err
}

Expand Down Expand Up @@ -96,11 +96,11 @@ func EndBlocker(ctx sdk.Context, keeper *keeper.Keeper) error {
proposal, err := keeper.Proposals.Get(ctx, key.K2())
if err != nil {
// if the proposal has an encoding error, this means it cannot be processed by x/gov
// this could be to some types missing their registration
// this could be due to some types missing their registration
// instead of returning an error (i.e, halting the chain), we fail the proposal
if errors.Is(err, collections.ErrEncoding) {
proposal.Id = key.K2()
if err := failUnsupportedProposal(logger, ctx, keeper, proposal, err.Error()); err != nil {
if err := failUnsupportedProposal(logger, ctx, keeper, proposal, err.Error(), true); err != nil {
return false, err
}

Expand Down Expand Up @@ -275,6 +275,7 @@ func failUnsupportedProposal(
keeper *keeper.Keeper,
proposal v1.Proposal,
errMsg string,
active bool,
) error {
proposal.Status = v1.StatusFailed
proposal.FailedReason = fmt.Sprintf("proposal failed because it cannot be processed by gov: %s", errMsg)
Expand All @@ -288,9 +289,14 @@ func failUnsupportedProposal(
return err
}

eventType := types.EventTypeInactiveProposal
if active {
eventType = types.EventTypeActiveProposal
}

ctx.EventManager().EmitEvent(
sdk.NewEvent(
types.EventTypeInactiveProposal,
eventType,
sdk.NewAttribute(types.AttributeKeyProposalID, fmt.Sprintf("%d", proposal.Id)),
sdk.NewAttribute(types.AttributeKeyProposalResult, types.AttributeValueProposalFailed),
),
Expand Down