refactor(client): use cmtservice for comet-validator-set command

[zakir998]

• replacement for deprecated PrintObjectLegacy method

[zakir998]

Impact on "comet-validator-set" cmd cli

current:

{"block_height":"4541","validators":[{"address":"cosmosvalcons1uh0dwj3u8nx9yh7dcj8lzlmpcunap7vrz94y43","pub_key":{"type":"tendermint/PubKeyEd25519","value":"Nnj0I8yxNgpe2swLEqDPqfNnJCDRenFXROCPp2ay87w="},"proposer_priority":"0","voting_power":"1"}],"total":"1"}

This PR:

{"block_height":"4004","validators":[{"address":"E5DED74A3C3CCC525FCDC48FF17F61C727D0F983","pub_key":{"type":"tendermint/PubKeyEd25519","value":"Nnj0I8yxNgpe2swLEqDPqfNnJCDRenFXROCPp2ay87w="},"voting_power":"1","proposer_priority":"0"}],"count":"1","total":"1"}

[julienrbrt]

Based on the output of above, I think we probably still want to display the bech32 address.

[zakir998]

Can use cmtservice.GetLatestValidatorSetResponse as output of comet-validator-set cmd.

{"block_height":"5307","validators":[{"address":"cosmosvalcons1uh0dwj3u8nx9yh7dcj8lzlmpcunap7vrz94y43","pub_key":{"@type":"/cosmos.crypto.ed25519.PubKey","key":"Nnj0I8yxNgpe2swLEqDPqfNnJCDRenFXROCPp2ay87w="},"voting_power":"1","proposer_priority":"0"}],"pagination":{"next_key":null,"total":"1"}}

[zakir998]

Also I think status and comet-validator-set commands can be moved to server.cmt_cmds.go

[julienrbrt]

Can use cmtservice.GetLatestValidatorSetResponse as output of comet-validator-set cmd.

{"block_height":"5307","validators":[{"address":"cosmosvalcons1uh0dwj3u8nx9yh7dcj8lzlmpcunap7vrz94y43","pub_key":{"@type":"/cosmos.crypto.ed25519.PubKey","key":"Nnj0I8yxNgpe2swLEqDPqfNnJCDRenFXROCPp2ay87w="},"voting_power":"1","proposer_priority":"0"}],"pagination":{"next_key":null,"total":"1"}}

Feels a bit hacky, but works! Eventually, I'll investigate how to use AutoCLI for these anyway.
Let's not move them just yet however as they will probably get replaced soon.

[zakir998]

Using AutoCLI is a good idea

[julienrbrt]

Could you fix the e2e tests and implement this comment: #17187 (comment)

[zakir998]

I have fixed the e2e tests. Please review the changes in the latest commit. Thank you for pointing out the issue in #17187 (comment).

[julienrbrt]

The address still does not have the same format as previously.

[zakir998]

I test again, The address is the same, the pub_key and total are different, I think it is necessary to keep the pub_key consistent with the type returned by other commands.

current:

{"block_height":"33","validators":[{"address":"cosmosvalcons1kpfyd2mxvse4wnq652cam3a73pwxk4a2uqaaws","pub_key":{"type":"tendermint/PubKeyEd25519","value":"YAmXz9KUXRRpNM1lDQEzt3gxHf9iFSVzRuiKFU4ExEA="},"proposer_priority":"0","voting_power":"1"}],"total":"1"}

This PR:

{"block_height":"6","validators":[{"address":"cosmosvalcons1kpfyd2mxvse4wnq652cam3a73pwxk4a2uqaaws","pub_key":{"@type":"/cosmos.crypto.ed25519.PubKey","key":"YAmXz9KUXRRpNM1lDQEzt3gxHf9iFSVzRuiKFU4ExEA="},"voting_power":"1","proposer_priority":"0"}],"pagination":{"next_key":null,"total":"1"}}

[julienrbrt]

tACK!