Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(x/tx): partly revert NewEncoder usage #16936

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Conversation

julienrbrt
Copy link
Member

Description

Partly revert #16684. Using the Encode methods adds an unnecessary newline.

This leads to a small diff when marshaling compared to previously https://github.com/cosmos/cosmos-sdk/actions/runs/5524118523/jobs/10075983329


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did we use a new encoder for any particular reason before?

@julienrbrt
Copy link
Member Author

julienrbrt commented Jul 13, 2023

LGTM, did we use a new encoder for any particular reason before?

It was to marshal directly to the writer. but we can still do that in two steps without significant perf impact for this case.

@julienrbrt julienrbrt added this pull request to the merge queue Jul 13, 2023
Merged via the queue into main with commit 936780b Jul 13, 2023
51 checks passed
@julienrbrt julienrbrt deleted the julien/remove-newline branch July 13, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants