Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify gov docs #16917

Merged
merged 1 commit into from
Jul 11, 2023
Merged

docs: Clarify gov docs #16917

merged 1 commit into from
Jul 11, 2023

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #16909


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 marked this pull request as ready for review July 11, 2023 09:34
@likhita-809 likhita-809 requested a review from a team as a code owner July 11, 2023 09:34
* **Inheritance and penalties:** Delegators inherit their validator's vote if
they don't vote themselves.
* **Claiming deposit:** Users that deposited on proposals can recover their
deposits if the proposal was accepted or rejected. If the proposal was vetoed, or never entered voting period, the deposit is burned.
deposits if the proposal was accepted or rejected. If the proposal was vetoed, or never entered voting period (minimum deposit not reached within deposit period), the deposit is burned.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the deposit burned even if we didn't veto it?

Copy link
Contributor

@atheeshp atheeshp Jul 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is a chance of burning the deposits based on the param burn_proposal_deposit_prevote ( bool ), if the proposal didn't reach the quorum to enter voting period the deposits will be burned or refunded (from v0.47).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@julienrbrt julienrbrt added backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Jul 11, 2023
@julienrbrt
Copy link
Member

@rootulp does this clarify it enough for you?

@rootulp
Copy link
Contributor

rootulp commented Jul 11, 2023

Yea LGTM! Thanks for the quick turnaround on this.

@julienrbrt julienrbrt added this pull request to the merge queue Jul 11, 2023
Merged via the queue into main with commit 06edd92 Jul 11, 2023
1 check passed
@julienrbrt julienrbrt deleted the likhita/gov-docs branch July 11, 2023 15:01
mergify bot pushed a commit that referenced this pull request Jul 11, 2023
(cherry picked from commit 06edd92)
mergify bot pushed a commit that referenced this pull request Jul 11, 2023
(cherry picked from commit 06edd92)
julienrbrt pushed a commit that referenced this pull request Jul 11, 2023
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
julienrbrt pushed a commit that referenced this pull request Jul 11, 2023
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/gov
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List of features for x/gov module isn't cohesive
5 participants