Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(authz): error msg #16869

Merged
merged 4 commits into from
Jul 7, 2023
Merged

fix(authz): error msg #16869

merged 4 commits into from
Jul 7, 2023

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Jul 7, 2023

Description

Closes: #16839

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp requested a review from a team as a code owner July 7, 2023 05:43
@github-actions

This comment has been minimized.

Sign in to view
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 7, 2023
julienrbrt
julienrbrt approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! We should add a changelog.

@atheeshp atheeshp enabled auto-merge July 7, 2023 06:38
likhita-809
likhita-809 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just nit

CHANGELOG.md Outdated Show resolved Hide resolved
@atheeshp @likhita-809
Update CHANGELOG.md
76a6085 
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
@atheeshp atheeshp added this pull request to the merge queue Jul 7, 2023
Merged via the queue into main with commit bf7a298 Jul 7, 2023
@atheeshp atheeshp deleted the ap/authz-error-msg branch July 7, 2023 10:12
mergify bot pushed a commit that referenced this pull request Jul 7, 2023
@atheeshp @mergify
fix(authz): error msg (#16869)
ba0f122 
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
(cherry picked from commit bf7a298)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Jul 7, 2023
Merged
julienrbrt added a commit that referenced this pull request Jul 7, 2023
@mergify @atheeshp @julienrbrt
fix(authz): error msg (backport #16869) (#16873)
26d3559 
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleem1314 aleem1314 aleem1314 left review comments

@julienrbrt julienrbrt julienrbrt approved these changes

@likhita-809 likhita-809 likhita-809 approved these changes

@aaronc aaronc Awaiting requested review from aaronc

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/authz
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[authz]: Improve error message when authz not found
4 participants
@atheeshp @julienrbrt @aleem1314 @likhita-809