Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: all: use io.WriteString instead of byteslice(string) conversion #16851

Merged

Conversation

odeke-em
Copy link
Collaborator

@odeke-em odeke-em commented Jul 6, 2023

This change switches to using io.WriteString instead of a primitive []byte(str) conversion.

/cc @elias-orijtech

This change switches to using io.WriteString instead of a primitive
[]byte(str) conversion.
@odeke-em odeke-em requested a review from a team as a code owner July 6, 2023 06:43
@github-prbot github-prbot requested review from a team, kocubinski and samricotta and removed request for a team July 6, 2023 06:43
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@julienrbrt julienrbrt added this pull request to the merge queue Jul 6, 2023
Merged via the queue into main with commit 4b557c9 Jul 6, 2023
@julienrbrt julienrbrt deleted the all-use-io.Write-instead-of-byteslice-string-conversion branch July 6, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants