Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changelog correction #16816

Merged
merged 1 commit into from
Jul 3, 2023
Merged

chore: changelog correction #16816

merged 1 commit into from
Jul 3, 2023

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Jul 3, 2023

Description

The removed two PR references got merged while resolving the conflicts.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp requested a review from a team as a code owner July 3, 2023 09:56
@github-prbot github-prbot requested review from a team, kocubinski and samricotta and removed request for a team July 3, 2023 09:56
@atheeshp atheeshp requested review from julienrbrt and removed request for kocubinski and samricotta July 3, 2023 09:56
@atheeshp atheeshp added this pull request to the merge queue Jul 3, 2023
Merged via the queue into main with commit 6b1acf7 Jul 3, 2023
@atheeshp atheeshp deleted the ap/changelog branch July 3, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants