-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(collections): add alternative value codec #16773
Conversation
Could we get a few docs in this feature as well |
docs added 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! However, I feel like the API does not convey immediately what it does.
I find the word “alternative”, while it is more a fallback, a bit confusing, just my two cents, however.
We can change the name if you feel it does not express well its role. I'm open to suggestions! |
I do not have a better suggestion 😅, it was simply not immediately clear for me what "alternative" meant by just reading the function arguments (without reading it or the godoc). |
@julienrbrt I think we can merge as is, worst case we can break this API, anyways it's intended for super advanced use-cases so I don't think a regular developer will really have to deal with this. |
Description
Closes: #16771
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change