Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: rm GetSignBytes #16062

Merged
merged 27 commits into from
May 30, 2023
Merged

refactor!: rm GetSignBytes #16062

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
3d7a2e7
refactor!: rm usages of .GetSignBytes
kocubinski May 11, 2023
8ea6ade
fix server/mock/app_test.go
kocubinski May 11, 2023
22972a0
"fix" x/bank simulation tests
kocubinski May 11, 2023
9c7ab5b
must sort json in ProtoCodec.MarshalAminoJSON
kocubinski May 12, 2023
14d288f
mv legacy coin format fn, fix distribution sims tests
kocubinski May 12, 2023
3021c32
fix lots of tests
kocubinski May 13, 2023
d1ba723
wip
kocubinski May 15, 2023
ca1a0b4
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/r…
kocubinski May 15, 2023
dfa22b1
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/r…
kocubinski May 15, 2023
4208d52
Add missing attribute to proto, other test fixes too
kocubinski May 15, 2023
d18763f
Something unknown happening in MsgSubmitProposal
kocubinski May 16, 2023
3869992
add missing annotation
kocubinski May 16, 2023
ff11dbd
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/r…
kocubinski May 16, 2023
56fc906
fix x/feegrant tests
kocubinski May 16, 2023
0b19b09
rm unneeded method
kocubinski May 16, 2023
da9d445
comment out deref in test
kocubinski May 16, 2023
dce0f2d
fix linter faults
kocubinski May 16, 2023
9a9dcbd
Add CHANGELOG
kocubinski May 16, 2023
a4d981d
Add UPGRADING notes
kocubinski May 16, 2023
ac10b70
fmt
kocubinski May 16, 2023
0f9e5a3
proofing
kocubinski May 16, 2023
beb7863
Merge branch 'main' into kocubinski/rm-getsignbytes
kocubinski May 16, 2023
6cfc30b
merge main
kocubinski May 30, 2023
d75af77
lint fixes
kocubinski May 30, 2023
6fa8d80
fix legacy amino test
kocubinski May 30, 2023
2ddc9ea
fix intergration tests
kocubinski May 30, 2023
b70101c
Merge branch 'main' into kocubinski/rm-getsignbytes
kocubinski May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix server/mock/app_test.go
  • Loading branch information
@kocubinski
kocubinski committed May 11, 2023
commit 8ea6ade6a6d9fa0e8118c3b0a8c370ec3a72a2be
3 changes: 1 addition & 2 deletions server/mock/app_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,13 @@ func TestDeliverTx(t *testing.T) {
randomAccounts := simtypes.RandomAccounts(r, 1)

tx := NewTx(key, value, randomAccounts[0].Address)
txBytes := tx.GetSignBytes()

app.BeginBlock(abci.RequestBeginBlock{Header: cmtproto.Header{
AppHash: []byte("apphash"),
Height: 1,
}})

dres := app.DeliverTx(abci.RequestDeliverTx{Tx: txBytes})
dres := app.DeliverTx(abci.RequestDeliverTx{Tx: tx.bytes})
require.Equal(t, uint32(0), dres.Code, dres.Log)

app.EndBlock(abci.RequestEndBlock{})
Expand Down