store: Setting default back to archive mode / no pruning

[UnitylChaos]

For testnets at least we should have the default be to keep all history so that bug hunting is easier.
Once other PRs (#1533 and #1580) come in we can have config / command line options to enable pruning manually for those that want to run lower disk usage nodes.

• Updated all relevant documentation in docs
• Updated all code comments where relevant
• Wrote tests
• Updated CHANGELOG.md
• Updated Gaia/Examples
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
• Added appropriate labels to PR (ex. wip, ready-for-review, docs)

[cwgoes]

Can this be a configuration parameter instead of a constant that we have to change every time? Even for the testnets, I think we just need a few "full archive" nodes for debugging; most users can run with pruning enabled.

[UnitylChaos]

Configuration parameter is definitely the plan, and what's being addressed in the other two PRs. I just thought we should have a quick change back so that we have the data, but I guess if everyone knows it's enabled, then we can just run some archive nodes for debugging purposes.

[ValarDragon]

Looks like #1580 is almost done though, do you think it won't be done by next testnet?

[UnitylChaos]

It could be merged now if approved. I would need to work on #1533 a bit to make use of it, but that could be done today if we aren't cutting the release till tonight or tomorrow.

[ValarDragon]

internal testnet might be today or tomorrow, definitely not 7000. (Still need 1-2 days to build that genesis file, and a method to convert pubkeys)

[alexanderbez]

Tbh, I think reverting this back makes sense for now until we find a reasonable approach on how to instantiate BaseApp in a clean and flexible manner (i.e. going with a context, using functional options, or some equivalent).

[alexanderbez]

@jlandrews the build failed due to TestGaiaCLISend which is non-deterministic, so I reran the job. Will given an approval once passing.

[codecov]

Codecov Report

Merging #1590 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1590   +/-   ##
========================================
  Coverage    64.18%   64.18%           
========================================
  Files          122      122           
  Lines         6674     6674           
========================================
  Hits          4284     4284           
  Misses        2145     2145           
  Partials       245      245

[alexanderbez]

LGTM, but we certainly should come to a decision on how to make BaseApp construction more flexible.

[cwgoes]

Merging for now since the other two PRs look to still be in progress.

Once they're merged I think we should set pruning as the default and require a config change to run an archive node though.

[alexanderbez]

+1 @cwgoes