Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(orm)!: rename orm package to use a vanity url #15870

Merged
merged 5 commits into from
Apr 18, 2023
Merged

Conversation

julienrbrt
Copy link
Member

Description

ref: cosmos/vanity#43, #15138 (comment)
I gladly use the right package in my group migration PR and have an extra beta tag with that renaming because the previous tag is quite old.

@aaronc what do you think of tagging another beta after this?


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from aaronc April 18, 2023 14:49
@julienrbrt julienrbrt requested a review from a team as a code owner April 18, 2023 14:49
@github-prbot github-prbot requested review from a team and tac0turtle and removed request for a team April 18, 2023 14:52
@github-actions github-actions bot added the C:orm label Apr 18, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Apr 18, 2023
@julienrbrt julienrbrt removed this pull request from the merge queue due to a manual request Apr 18, 2023
@julienrbrt julienrbrt enabled auto-merge April 18, 2023 16:38
@julienrbrt julienrbrt added this pull request to the merge queue Apr 18, 2023
Merged via the queue into main with commit 58f3a4a Apr 18, 2023
@julienrbrt julienrbrt deleted the julien/vanity-orm branch April 18, 2023 17:00
@julienrbrt
Copy link
Member Author

Tagged https://github.com/cosmos/cosmos-sdk/releases/tag/orm%2Fv1.0.0-beta.1 with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants