refactor(auth): use collections for GlobalAccountNumber #15830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
kocubinski and
julienrbrt
and removed request for
a team
testinginprod
commented
Apr 13, 2023
| @@ -6,7 +6,7 @@ import ( | |||
| ) | |||
|
|
|||
| // DefaultSequenceStart defines the default starting number of a sequence. | |||
| const DefaultSequenceStart uint64 = 1 | |||
| const DefaultSequenceStart uint64 = 0 | |||
There was a problem hiding this comment.
modified this to make it match the account number semantics, which start from zero.
testinginprod
commented
Apr 13, 2023
| func MockStore() (store.KVStoreService, context.Context) { | ||
| // They can be used to test collections. The StoreService.NewStoreContext | ||
| // can be used to instantiate a new empty KVStore. | ||
| func MockStore() (*StoreService, context.Context) { |
There was a problem hiding this comment.
changes here allow the MockStore to properly match the design of the KVStoreService.
tac0turtle
approved these changes
Apr 13, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
julienrbrt
requested changes
Apr 14, 2023
x/auth/module.go
Outdated
| @@ -151,6 +151,10 @@ func (am AppModule) RegisterServices(cfg module.Configurator) { | |||
| if err := cfg.RegisterMigration(types.ModuleName, 4, func(ctx sdk.Context) error { return nil }); err != nil { | |||
| panic(fmt.Sprintf("failed to migrate x/%s from version 4 to 5: %v", types.ModuleName, err)) | |||
| } | |||
|
|
|||
| if err := cfg.RegisterMigration(types.ModuleName, 5, m.Migrate5to6); err != nil { | |||
There was a problem hiding this comment.
This is actually migration 4 to 5, as migration 4 was for v0.47. You can as well delete the placeholder for migration to 5, which wasn't necessary (#14483 (comment))
julienrbrt
reviewed
Apr 14, 2023
19 tasks
julienrbrt
reviewed
Apr 14, 2023
added 2 commits
April 17, 2023 10:31
added 2 commits
April 17, 2023 10:36
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Co-authored-by: testinginprod <testinginprod@somewhere.idk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #15831
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change