Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use rc3 in release/v0.47.x #15224

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Conversation

julienrbrt
Copy link
Member

Description

Small chore PR to use rc3 in rosetta.
Updating simapp to v0.47.0 so it shows v0.47 when we call version.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner March 1, 2023 16:43
@github-actions github-actions bot added C:Cosmovisor Issues and PR related to Cosmovisor C:Rosetta Issues and PR related to Rosetta labels Mar 1, 2023
@julienrbrt julienrbrt enabled auto-merge (squash) March 1, 2023 17:45
@@ -9,7 +9,7 @@ require (
cosmossdk.io/simapp v0.0.0-00010101000000-000000000000
github.com/cometbft/cometbft v0.37.0-rc3
github.com/cometbft/cometbft-db v0.7.0
github.com/cosmos/cosmos-sdk v0.47.0-rc2.0.20230220103612-f094a0c33410
github.com/cosmos/cosmos-sdk v0.47.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt this be -rc3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No because tests and simapp uses a replace, the version we input does not matter. For simapp version to show the proper SDK version, we simply just set the version of the release branch.
For instance, on main it is set to v0.48 (as it's the next version coming).

@julienrbrt julienrbrt merged commit e598472 into release/v0.47.x Mar 2, 2023
@julienrbrt julienrbrt deleted the julien/chore-rc3 branch March 2, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Cosmovisor Issues and PR related to Cosmovisor C:Rosetta Issues and PR related to Rosetta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants