Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove MsgResponses from PostHandler #14522

Conversation

Vvaradinov
Copy link
Contributor

@Vvaradinov Vvaradinov commented Jan 6, 2023

Description

This PR just fixes an issue with the test suite caused by generating mocks.

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@Vvaradinov Vvaradinov requested a review from a team as a code owner January 6, 2023 14:55
@facundomedica
Copy link
Member

Hey! Could you please add some context to the description? Thank you!!

@julienrbrt
Copy link
Member

Pinging @fedekunze as it targets his branch.

@Vvaradinov Vvaradinov changed the title fix: fixed test case error fix: update PostHandler to receive GasMeter Jan 9, 2023
baseapp/baseapp.go Outdated Show resolved Hide resolved
types/handler.go Outdated Show resolved Hide resolved
@Vvaradinov Vvaradinov changed the title fix: update PostHandler to receive GasMeter fix: remove MsgResponses from PostHandler Jan 9, 2023
@fedekunze fedekunze merged commit 6277794 into cosmos:fedekunze/update-posthandlers Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants