Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: (x/feegrant) update keeper logic to do not allow duplicate grant #14294

Merged
merged 14 commits into from
Jan 9, 2023
Merged

chore: (x/feegrant) update keeper logic to do not allow duplicate grant #14294

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
fcc5eb5
chore: (x/feegrant) update keeper logic to do not allow dupl9cate grant
atheeshp Dec 14, 2022
6662169
Merge branch 'main' into ap/cleanup_feegrant
alexanderbez Dec 15, 2022
c39b6b4
review changes
atheeshp Dec 21, 2022
1a26624
Merge branch 'ap/cleanup_feegrant' of github.com:cosmos/cosmos-sdk in…
atheeshp Dec 21, 2022
93e2b22
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/cleanup_f…
atheeshp Dec 21, 2022
dd5a28e
update changelog
atheeshp Dec 21, 2022
1a1e605
Merge branch 'main' into ap/cleanup_feegrant
atheeshp Dec 26, 2022
c9c06e7
Merge branch 'main' into ap/cleanup_feegrant
atheeshp Dec 27, 2022
89a30d9
Merge branch 'main' into ap/cleanup_feegrant
atheeshp Jan 2, 2023
181f4fc
Merge branch 'main' into ap/cleanup_feegrant
atheeshp Jan 4, 2023
c806587
Merge branch 'main' into ap/cleanup_feegrant
atheeshp Jan 9, 2023
6481d32
Update x/feegrant/keeper/keeper_test.go
atheeshp Jan 9, 2023
68f3094
Merge branch 'main' into ap/cleanup_feegrant
julienrbrt Jan 9, 2023
53199e0
imp changelog
julienrbrt Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review changes
  • Loading branch information
@atheeshp
atheeshp committed Dec 21, 2022
commit c39b6b44db54f68fc866a3c3dd50ea184a874e42
6 changes: 0 additions & 6 deletions x/feegrant/keeper/msg_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (

sdk "github.com/cosmos/cosmos-sdk/types"

sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
"github.com/cosmos/cosmos-sdk/x/feegrant"
)

Expand Down Expand Up @@ -37,11 +36,6 @@ func (k msgServer) GrantAllowance(goCtx context.Context, msg *feegrant.MsgGrantA
return nil, err
}

// Checking for duplicate entry
if f, _ := k.Keeper.GetAllowance(ctx, granter, grantee); f != nil {
return nil, sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, "fee allowance already exists")
}

allowance, err := msg.GetFeeAllowanceI()
if err != nil {
return nil, err
Expand Down