Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: key presentation outside keyring #14151

Merged
merged 6 commits into from
Dec 7, 2022
Merged

refactor!: key presentation outside keyring #14151

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7d60254
refactor: move key presentation to client/keys
JulianToledano Dec 5, 2022
5a206d4
refactor: move key presentation to client/keys
JulianToledano Dec 5, 2022
538623d
Merge remote-tracking branch 'origin/key-presentation-outside-keyring…
JulianToledano Dec 5, 2022
c42daa0
update: changelog
JulianToledano Dec 5, 2022
33593bd
Merge branch 'main' into key-presentation-outside-keyring
raynaudoe Dec 6, 2022
c8706db
Merge branch 'main' into key-presentation-outside-keyring
JulianToledano Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update: changelog
  • Loading branch information
@JulianToledano
JulianToledano committed Dec 5, 2022
commit c42daa0671b6d4f06b790e8dfeaa3ab709f46487
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Improvements

* (crypto/keyring) [#14151](https://github.com/cosmos/cosmos-sdk/pull/14151) Move keys presentation from `crypto/keyring` to `client/keys`
* (signing) [#14087](https://github.com/cosmos/cosmos-sdk/pull/14087) Add SignModeHandlerWithContext interface with a new `GetSignBytesWithContext` to get the sign bytes using `context.Context` as an argument to access state.
* (server) [#14062](https://github.com/cosmos/cosmos-sdk/pull/14062) Remove rosetta from server start.
* [13882] (https://github.com/cosmos/cosmos-sdk/pull/13882) Add tx `encode` and `decode` endpoints to amino tx service.
Expand Down Expand Up @@ -126,6 +127,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### API Breaking Changes

* (crypto/keyring) [#14151](https://github.com/cosmos/cosmos-sdk/pull/14151) Move keys presentation from `crypto/keyring` to `client/keys`
* (modules) [#13850](https://github.com/cosmos/cosmos-sdk/pull/13850) and [#14046](https://github.com/cosmos/cosmos-sdk/pull/14046) Remove gogoproto stringer annotations. This removes the custom `String()` methods on all types that were using the annotations.
* (x/auth) [#13850](https://github.com/cosmos/cosmos-sdk/pull/13850/) Remove `MarshalYAML` methods from module (`x/...`) types.
* (x/auth) [#13877](https://github.com/cosmos/cosmos-sdk/pull/13877) Rename `AccountKeeper`'s `GetNextAccountNumber` to `NextAccountNumber`.
Expand Down