-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(textual): Update Spec to have shorter Any header screen #14117
Conversation
[Cosmos SDK Core] Kudos, SonarCloud Quality Gate passed! |
acaf522
to
30ad26f
Compare
Thanks for the reviews! I would also like someone from the Textual WG to approve this before merging. |
{"text": "/google.protobuf.Any"}, | ||
{"text": "/Foo", "indent": 1}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only weird output would be this.
The first line will have, in a message context, a field name:
<Field>: /google.protobuf.Any
But the 2nd line will be a naked /Foo
. I think it's fine, because nested packed Anys should be extremely rare.
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed! |
@@ -4,7 +4,7 @@ | |||
"@type": "/Foo" | |||
}, | |||
"screens": [ | |||
{"text": "Object: /Foo"}, | |||
{"text": "/Foo"}, | |||
{"text": "Foo object", "indent": 1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we still say Foo object
after /Foo
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We touched on this in yesterday's call, but didn't come to a unanimous conclusion, so here's an issue to discuss more: #14170
[Cosmos SDK - Tx] Kudos, SonarCloud Quality Gate passed! |
Description
This is a proposal for spec update on Any value renderers to remove the
Object:
prefix on its header screen. I found out in #13600 that they "object" word came up unnecessarily too often:An Any can only pack a protobuf message, so it's always going to be Object. That's why I propose to omit it.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change