Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: undo sdk/types import in store. #14096

Merged
merged 16 commits into from
Dec 6, 2022
Merged

refactor: undo sdk/types import in store. #14096

merged 16 commits into from
Dec 6, 2022

Conversation

tac0turtle
Copy link
Member

Description

reduce reliance on sdk/types in store package.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Base automatically changed from marko/errors_store to main December 3, 2022 13:11
@tac0turtle tac0turtle marked this pull request as ready for review December 3, 2022 21:08
@tac0turtle tac0turtle requested a review from a team as a code owner December 3, 2022 21:08
odeke-em
odeke-em reviewed Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @tac0turtle! I've added a review, please take a look.

store/streaming/file/service_test.go Outdated Show resolved Hide resolved
store/types/utils.go Outdated Show resolved Hide resolved
likhita-809
likhita-809 approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit, overall lgtm

store/types/utils.go Outdated Show resolved Hide resolved
@tac0turtle tac0turtle enabled auto-merge (squash) December 6, 2022 10:18
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Dec 6, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2022

[Cosmos SDK] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

6.2% 6.2% Coverage
0.0% 0.0% Duplication

@tac0turtle tac0turtle merged commit 14c9dc6 into main Dec 6, 2022
@tac0turtle tac0turtle deleted the marko/sdk_type_deps branch December 6, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odeke-em odeke-em odeke-em left review comments

@likhita-809 likhita-809 likhita-809 approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

Assignees

@alexanderbez alexanderbez

@likhita-809 likhita-809

Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Store
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tac0turtle @odeke-em @alexanderbez @likhita-809