fix: store/rootmulti: correctly dispatch exporter closing while in a loop #14027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loop The prior code used defers in a loop as a precaution for if any error was encountered in the loop then later invoked exporter.Close() at the bottom of the loop. However, that's a precarious situation that is entirely be fixed by using a closure and the defer .Close() as well. An illustration for avoiding defers in a loop: https://go.dev/play/p/i3y1emcxNZK as they won't correctly run. Fixes #14026
odeke-em
force-pushed
the
store-rootmulti-fix-Store.Snapshot-defers-misuse-in-loop
branch
from
5819ca4 to
3eb30f1
Compare
18 tasks
|
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed! |
alexanderbez
approved these changes
Nov 29, 2022
odeke-em
deleted the
store-rootmulti-fix-Store.Snapshot-defers-misuse-in-loop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior code used defers in a loop as a precaution for if any error was encountered in the loop then later invoked exporter.Close() at the bottom of the loop. However, that's a precarious situation that is entirely be fixed by using a closure and the defer .Close() as well.
An illustration for avoiding defers in a loop: https://go.dev/play/p/i3y1emcxNZK
as they won't correctly run.
Fixes #14026