feat(textual): Add Enum value renderer #13853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13853 +/- ##
==========================================
+ Coverage 56.25% 56.37% +0.11%
==========================================
Files 667 677 +10
Lines 56576 57011 +435
==========================================
+ Hits 31829 32142 +313
- Misses 22165 22249 +84
- Partials 2582 2620 +38
|
amaury1093
commented
Nov 14, 2022
Comment on lines
-166
to
-172
| - String case convention: snake case to sentence case | ||
| - Allow optional annotation for textual name (TBD) | ||
| - Algorithm: | ||
| - convert enum name (`VoteOption`) to snake_case (`VOTE_OPTION`) | ||
| - truncate that prefix + `_` from the enum name if it exists (`VOTE_OPTION_` gets stripped from `VOTE_OPTION_YES` -> `YES`) | ||
| - convert rest to sentence case: `YES` -> `Yes` | ||
| - in summary: `VOTE_OPTION_YES` -> `Yes` |
There was a problem hiding this comment.
I removed all string transformation we initially had. It can be ambiguous even for Format.
Take:
enum AbC {
D = 1;
AB_C_D = 2;
}I propose to go with simplicity with no transformation.
…os-sdk into am/12712-textual-enums
4 tasks
likhita-809
reviewed
Nov 22, 2022
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
likhita-809
approved these changes
Nov 23, 2022
|
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed! |
julienrbrt
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #12712
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change