fix: fix proto files created as super-user #13801
Conversation
julienrbrt
force-pushed
the
julien/proto
branch
from
aa6e5f9 to
b4a3ea5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13801 +/- ##
==========================================
+ Coverage 56.71% 56.78% +0.06%
==========================================
Files 635 644 +9
Lines 54547 54952 +405
==========================================
+ Hits 30937 31204 +267
- Misses 21107 21209 +102
- Partials 2503 2539 +36
|
julienrbrt
changed the title
| @@ -408,38 +408,30 @@ devdoc-update: | |||
| ### Protobuf ### | |||
| ############################################################################### | |||
|
|
|||
| protoVer=0.11.0 | |||
| protoVer=0.11.2 | |||
There was a problem hiding this comment.
As I have modified the dockerfile, bumping to 0.11.2.
The person merging must not forget to trigger the image build
| @@ -408,38 +408,30 @@ devdoc-update: | |||
| ### Protobuf ### | |||
| ############################################################################### | |||
|
|
|||
| protoVer=0.11.0 | |||
| protoVer=0.11.2 | |||
| protoImageName=ghcr.io/cosmos/proto-builder:$(protoVer) | |||
There was a problem hiding this comment.
Run docker build --pull --rm -f "contrib/devtools/Dockerfile" -t cosmossdk-proto:latest "contrib/devtools" and replace this line by cosmossdk-proto:latest for testing locally.
There was a problem hiding this comment.
I would love to have someone using macOS try this.
There was a problem hiding this comment.
locally all works for me. Ran all the commands, thanks for this
There was a problem hiding this comment.
Can you check the permission of the api folder and the proto/tendermint folder? It should be not be root.
Description
Follow-up of #13791 to bump the image in the Makefile.
Additionally, let all proto-* commands use the
proto-builderimage. This prevents the buf version to differ from theproto-builderimage and the one we were using in the Makefile.Ran
make proto-update-deps,make proto-format,make proto-genFixes #12150
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change