Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: remove GetMemo from Tx #1377

Merged
merged 1 commit into from
Jun 26, 2018
Merged

types: remove GetMemo from Tx #1377

merged 1 commit into from
Jun 26, 2018

Conversation

ValarDragon
Copy link
Contributor

@ValarDragon ValarDragon commented Jun 26, 2018 •
edited
Loading

This method is an unneccessary requirement on Tx. Auth casts the Tx
to StdTx, so the memo can be obtained in previous usecases from
StdTx. This also makes it more clear for when something is
implementing StdTx vs Tx.

Resolves #1375

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated Gaia/Examples
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@ValarDragon
types: remove GetMemo from Tx
b2f6a04 
This method is an unneccessary requirement on Tx. Auth casts the Tx
to StdTx, so the memo can be obtained in previous usecases from
StdTx. This also makes it more clear for when something is
implementing StdTx vs Tx.

Resolves #1375
@ValarDragon ValarDragon requested review from ebuchman and cwgoes June 26, 2018 02:19
cwgoes
cwgoes approved these changes Jun 26, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit 893bb40 into develop Jun 26, 2018
@cwgoes cwgoes deleted the dev/remove_getmemo_from_tx branch June 26, 2018 02:37
@cwgoes
Copy link
Contributor

cwgoes commented Jun 26, 2018 •
edited
Loading

Note: I think we also have GetMemo() on some test transaction types - left as a testcase for our new linter suite - #1372 - hopefully we can catch unused methods.

@ValarDragon
Copy link
Contributor Author

I didn't remove those since I thought those needed to implement StdTx

@cwgoes
Copy link
Contributor

cwgoes commented Jun 26, 2018

I didn't remove those since I thought those needed to implement StdTx

Probably we should have at least one which doesn't if we want (part of) the SDK to be StdTx-independent? Not sure if we do though.

adrianbrink pushed a commit that referenced this pull request Jul 2, 2018
@ValarDragon
Merge PR #1377: types: remove GetMemo from Tx
dd2f4f9 
This method is an unneccessary requirement on Tx. Auth casts the Tx
to StdTx, so the memo can be obtained in previous usecases from
StdTx. This also makes it more clear for when something is
implementing StdTx vs Tx.

Resolves #1375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValarDragon @cwgoes