Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix redirections links #13465

Merged
merged 2 commits into from
Oct 6, 2022
Merged

fix: fix redirections links #13465

merged 2 commits into from
Oct 6, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Oct 6, 2022

Description

Based on tendermint/tendermint#9311.
Redirects links worked, but were not copied to the root of the website. Leading to the #11798 again.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner October 6, 2022 14:25
@julienrbrt julienrbrt enabled auto-merge (squash) October 6, 2022 14:26
@julienrbrt
Copy link
Member Author

Working on my machine too. This time I have left all the versions for trying (instead of having only one to save time).

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yoloACK

@julienrbrt julienrbrt merged commit 5878976 into main Oct 6, 2022
@julienrbrt julienrbrt deleted the julien/docs branch October 6, 2022 17:04
@julienrbrt
Copy link
Member Author

Working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants