-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: collapse module spec and readme #13143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we do all modules in one PR? You need to modify this file too, so it points to the right README: https://raw.githubusercontent.com/cosmos/cosmos-sdk/ccdc355eea4eecac72395b7660b757ca45d394f1/x/README.md.
Which means you'll need to update https://github.com/cosmos/cosmos-sdk/blob/main/docs/pre.sh.
I think we should do all modules together: otherwise they won't appear anymore on docs.cosmos.network till pre.sh
is updated.
No, that would be too much for one author.
How? This is on |
It will still appear in releases, but for those who bookmarked /main, the bank module spec will be broken. |
lets do all in one, its not a heavy lift |
We can do all in one, sure. But I still fail to see what this has to do with the webapp for displaying docs. |
@marbar3778 can you comment on what modules you will take care of so I can do the rest, please? |
9b5e2de
to
1cc93fe
Compare
This is because we build the docs based on the |
Wow, you guys are amazing. Thank you for the hard work 👏 |
Description
closes: #6779
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change