Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unit test with mocks to x/genutil #13007

Merged
merged 7 commits into from
Aug 24, 2022

Conversation

JeancarloBarrios
Copy link
Contributor

@JeancarloBarrios JeancarloBarrios commented Aug 23, 2022

Description

Closes: #12759


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:x/genutil genutil module issues Type: Build labels Aug 23, 2022
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #13007 (65651c4) into main (4fe7797) will decrease coverage by 0.03%.
The diff coverage is 63.42%.

❗ Current head 65651c4 differs from pull request most recent head 7689dbc. Consider uploading reports for the commit 7689dbc to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13007      +/-   ##
==========================================
- Coverage   55.87%   55.84%   -0.04%     
==========================================
  Files         646      649       +3     
  Lines       54895    55022     +127     
==========================================
+ Hits        30675    30726      +51     
- Misses      21762    21823      +61     
- Partials     2458     2473      +15     
Impacted Files Coverage Δ
baseapp/abci.go 64.09% <0.00%> (-0.33%) ⬇️
client/flags/flags.go 19.35% <0.00%> (-0.32%) ⬇️
client/rpc/status.go 66.66% <ø> (ø)
client/utils.go 34.92% <0.00%> (ø)
server/config/config.go 38.00% <0.00%> (-1.59%) ⬇️
server/rosetta/client_online.go 1.35% <0.00%> (ø)
server/swagger.go 0.00% <0.00%> (ø)
testutil/list.go 0.00% <0.00%> (ø)
types/result.go 76.74% <ø> (ø)
x/auth/tx/query.go 0.00% <ø> (ø)
... and 68 more

@JeancarloBarrios JeancarloBarrios marked this pull request as ready for review August 23, 2022 21:29
@JeancarloBarrios JeancarloBarrios requested a review from a team as a code owner August 23, 2022 21:29
@JeancarloBarrios JeancarloBarrios added A:automerge Automatically merge PR once all prerequisites pass. and removed A:automerge Automatically merge PR once all prerequisites pass. labels Aug 24, 2022
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all the blank imports necessary? Moreover, is the file name correct or is it a typo?

x/genutil/gentxu_test.go Outdated Show resolved Hide resolved
JeancarloBarrios and others added 4 commits August 24, 2022 06:49
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
…b.com:cosmos/cosmos-sdk into JeancarloBarrios/migrate-genutil-to-unit-mock
@JeancarloBarrios
Copy link
Contributor Author

Are all the blank imports necessary? Moreover, is the file name correct or is it a typo?

Yes it was a typo

@JeancarloBarrios JeancarloBarrios added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 24, 2022
@mergify mergify bot merged commit 07c549b into main Aug 24, 2022
@mergify mergify bot deleted the JeancarloBarrios/migrate-genutil-to-unit-mock branch August 24, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/genutil genutil module issues Type: Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rewrite x/gentutil integration tests to use mocks
4 participants