Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add proposer removal changelog #12941

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Conversation

julienrbrt
Copy link
Member

Description

Follow-up of #12876

  • add changelog
  • remove unnecessary (and wrong) test.

cc @alexanderbez


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner August 17, 2022 12:25
@github-actions github-actions bot added the C:x/distribution distribution module related label Aug 17, 2022
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 17, 2022
@alexanderbez alexanderbez merged commit 2d01871 into main Aug 17, 2022
@alexanderbez alexanderbez deleted the julien/remove-unused-test branch August 17, 2022 14:54
@alexanderbez
Copy link
Contributor

Wow, not sure how I missed that. Thank you so much <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/distribution distribution module related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants