chore: improve proto formatting #12656
Merged
+364
−336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:orm
C:x/distribution
amaury1093
approved these changes
Jul 20, 2022
tac0turtle
reviewed
Jul 20, 2022
| @@ -7,31 +7,33 @@ import "google/protobuf/duration.proto"; | |||
| import "cosmos/orm/v1/orm.proto"; | |||
|
|
|||
| message ExampleTable { | |||
| // clang-format off | |||
There was a problem hiding this comment.
not a crazy fan about these. it seems to add overhead in the .pb.go files Are we able to remove these?
There was a problem hiding this comment.
It does not add anything in the .pb.go. make proto-all added unrelated changes. If you like, I can only run make proto-format in this PR.
I agree the comments are not super useful, but it does make the proto file way easier to read with correct indentation. It is only required for cosmos.orm.v1.table.
There was a problem hiding this comment.
ah nvm ignore the comment. Was weird how the bytes changed
alexanderbez
approved these changes
Jul 21, 2022
alexanderbez
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up on #12643 (comment)
Turns out, we need to disable the formatter for
cosmos.orm.v1.table.I have not found any option for doing that directly in the
.clang-formatconfig file.There was a typo as well for the formatter style. It should have been
Googleinstead ofgoogle.I have re-ran
make proto-allas well.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change