Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/query version #1252

Merged
merged 2 commits into from
Jun 14, 2018
Merged

Fabo/query version #1252

merged 2 commits into from
Jun 14, 2018

Conversation

faboweb
Copy link
Contributor

@faboweb faboweb commented Jun 14, 2018

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated Gaia/Examples
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@faboweb faboweb requested a review from ebuchman as a code owner June 14, 2018 01:06
@faboweb faboweb force-pushed the fabo/query-version branch from 2387ead to b6fb5d0 Compare June 14, 2018 01:09
@codecov
Copy link

codecov bot commented Jun 14, 2018

Codecov Report

Merging #1252 into develop will decrease coverage by 0.06%.
The diff coverage is 52.94%.

@@             Coverage Diff             @@
##           develop    #1252      +/-   ##
===========================================
- Coverage    68.62%   68.56%   -0.07%     
===========================================
  Files           86       87       +1     
  Lines         4504     4520      +16     
===========================================
+ Hits          3091     3099       +8     
- Misses        1221     1228       +7     
- Partials       192      193       +1

introduce non store queries

add version query


update lcd spec

changelog
moved version query into baseapp
@faboweb faboweb force-pushed the fabo/query-version branch from 23d0f79 to 3489ec7 Compare June 14, 2018 01:47
@faboweb faboweb changed the base branch from master to develop June 14, 2018 01:49
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit 42e7295 into develop Jun 14, 2018
@cwgoes cwgoes deleted the fabo/query-version branch June 14, 2018 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants