Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cosmovisor): Add a restart delay after halt and before backup #12188

Merged
merged 10 commits into from
Jun 9, 2022

Conversation

julienrbrt
Copy link
Member

Description

Closes: #12101


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner June 8, 2022 11:08
@julienrbrt julienrbrt linked an issue Jun 8, 2022 that may be closed by this pull request
4 tasks
@github-actions github-actions bot added the C:Cosmovisor Issues and PR related to Cosmovisor label Jun 8, 2022
cosmovisor/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cosmovisor/args.go Outdated Show resolved Hide resolved
cosmovisor/args.go Outdated Show resolved Hide resolved
cosmovisor/args.go Outdated Show resolved Hide resolved
julienrbrt and others added 4 commits June 9, 2022 18:29
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #12188 (1286679) into main (ce25dd2) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12188      +/-   ##
==========================================
+ Coverage   66.14%   66.17%   +0.03%     
==========================================
  Files         672      683      +11     
  Lines       70990    71742     +752     
==========================================
+ Hits        46954    47473     +519     
- Misses      21400    21599     +199     
- Partials     2636     2670      +34     
Impacted Files Coverage Δ
cosmovisor/args.go 86.06% <100.00%> (ø)
cosmovisor/process.go 51.31% <100.00%> (ø)
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️
cosmovisor/errors/multi.go 75.00% <0.00%> (ø)
cosmovisor/cmd/cosmovisor/main.go 0.00% <0.00%> (ø)
cosmovisor/cmd/cosmovisor/run.go 23.33% <0.00%> (ø)
cosmovisor/upgrade.go 75.72% <0.00%> (ø)
cosmovisor/cmd/cosmovisor/version.go 28.88% <0.00%> (ø)
cosmovisor/cmd/cosmovisor/help.go 100.00% <0.00%> (ø)
... and 5 more

Copy link
Collaborator

@dwedul-figure dwedul-figure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cosmovisor/args.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 9, 2022
@mergify mergify bot merged commit f1196ad into main Jun 9, 2022
@mergify mergify bot deleted the julien/12101-add-a-delay-after-halt-and-before-backup branch June 9, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Cosmovisor Issues and PR related to Cosmovisor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a delay after halt and before backup.
4 participants