Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Rename AccAddressFromHex #11888

Merged
merged 9 commits into from
May 6, 2022
Merged

refactor!: Rename AccAddressFromHex #11888

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
39c2692
updates
alexanderbez May 6, 2022
c678ff1
Merge branch 'main' into bez/11881-hex-addr-unsafe
mergify[bot] May 6, 2022
4ac833c
updates
alexanderbez May 6, 2022
2600e5f
Update types/address.go
alexanderbez May 6, 2022
01a72a7
updates
alexanderbez May 6, 2022
9125c76
Merge branch 'bez/11881-hex-addr-unsafe' of github.com:cosmos/cosmos-…
alexanderbez May 6, 2022
0b154b0
Merge branch 'main' into bez/11881-hex-addr-unsafe
alexanderbez May 6, 2022
19ff07b
Merge branch 'main' into bez/11881-hex-addr-unsafe
alexanderbez May 6, 2022
071dad0
updates
alexanderbez May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updates
  • Loading branch information
@alexanderbez
alexanderbez committed May 6, 2022
commit 01a72a712164bfb51ecac2bfb0b47cbe5735a34d
6 changes: 3 additions & 3 deletions types/address_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ func (s *addressTestSuite) TestRandBech32AccAddrConsistency() {
}

_, err := types.AccAddressFromHexUnsafe("")
s.Require().Equal("decoding Bech32 address failed: must provide an address", err.Error())
s.Require().Equal("decoding Bech32 address from hex string failed: empty address", err.Error())
}

func (s *addressTestSuite) TestValAddr() {
Expand Down Expand Up @@ -163,7 +163,7 @@ func (s *addressTestSuite) TestValAddr() {

// test empty string
_, err := types.ValAddressFromHex("")
s.Require().Equal("decoding Bech32 address failed: must provide an address", err.Error())
s.Require().Equal("decoding Bech32 address from hex string failed: empty address", err.Error())
}

func (s *addressTestSuite) TestConsAddress() {
Expand Down Expand Up @@ -203,7 +203,7 @@ func (s *addressTestSuite) TestConsAddress() {

// test empty string
_, err := types.ConsAddressFromHex("")
s.Require().Equal("decoding Bech32 address failed: must provide an address", err.Error())
s.Require().Equal("decoding Bech32 address from hex string failed: empty address", err.Error())
}

const letterBytes = "abcdefghijklmnopqrstuvwxyz"
Expand Down