Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix gh docs action #11547

Merged
merged 2 commits into from
Apr 5, 2022
Merged

ci: fix gh docs action #11547

merged 2 commits into from
Apr 5, 2022

Conversation

julienrbrt
Copy link
Member

Description

Set the output folder for building the docs back in ~ as it was being overwritten by each version build (effectively only keeping the latest).


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from tac0turtle April 5, 2022 11:38
@julienrbrt julienrbrt marked this pull request as ready for review April 5, 2022 11:40
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could also copy the cname into output after everything builds?

@julienrbrt
Copy link
Member Author

you could also copy the cname into output after everything builds?

Good point, it should indeed not be in the loop

@tac0turtle tac0turtle merged commit 37a52af into master Apr 5, 2022
@tac0turtle tac0turtle deleted the julien/fix-gh-docs-action branch April 5, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants