Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(orm): allow bytes keys longer than 255 bytes #11522

Merged
merged 6 commits into from
Apr 1, 2022

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Mar 31, 2022

Description

Closes: #11381


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:orm label Mar 31, 2022
@aaronc aaronc changed the title aaronc/11381-orm-bytes-255 feat(orm): allow bytes keys longer than 255 bytes Mar 31, 2022
@aaronc aaronc marked this pull request as ready for review March 31, 2022 19:00
@aaronc aaronc requested a review from alexanderbez as a code owner March 31, 2022 19:00
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #11522 (969db41) into master (3cf11e1) will increase coverage by 0.15%.
The diff coverage is 68.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11522      +/-   ##
==========================================
+ Coverage   65.96%   66.11%   +0.15%     
==========================================
  Files         675      715      +40     
  Lines       69832    72876    +3044     
==========================================
+ Hits        46065    48183    +2118     
- Misses      21073    21743     +670     
- Partials     2694     2950     +256     
Impacted Files Coverage Δ
types/tx/ext.go 0.00% <0.00%> (ø)
types/tx/types.go 0.00% <0.00%> (ø)
x/auth/middleware/msg_service_router.go 80.59% <0.00%> (ø)
x/gov/keeper/deposit.go 81.14% <ø> (ø)
x/gov/keeper/grpc_query.go 58.12% <ø> (ø)
x/gov/keeper/keeper.go 77.10% <ø> (ø)
x/group/keeper/invariants.go 53.62% <ø> (+10.12%) ⬆️
x/genutil/gentx.go 86.15% <33.33%> (-2.56%) ⬇️
x/genutil/types/genesis_state.go 50.00% <55.55%> (-1.57%) ⬇️
x/auth/middleware/ext.go 61.76% <63.15%> (-6.24%) ⬇️
... and 49 more

orm/encoding/ormfield/bytes.go Show resolved Hide resolved
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left few suggestions

orm/encoding/ormfield/bytes.go Outdated Show resolved Hide resolved
orm/encoding/ormfield/bytes.go Outdated Show resolved Hide resolved
orm/encoding/ormfield/bytes.go Show resolved Hide resolved
orm/encoding/ormfield/bytes.go Show resolved Hide resolved
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
@aaronc aaronc added A:automerge Automatically merge PR once all prerequisites pass. and removed A:automerge Automatically merge PR once all prerequisites pass. labels Apr 1, 2022
@aaronc aaronc added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 1, 2022
@mergify mergify bot merged commit 44a1293 into master Apr 1, 2022
@mergify mergify bot deleted the aaronc/11381-orm-bytes-255 branch April 1, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:orm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ORM: allow bytes keys longer than 255 bytes
3 participants