Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): use correct bit length constant for sdk.Dec #11332

Merged
merged 2 commits into from
Mar 8, 2022
Merged

fix(types): use correct bit length constant for sdk.Dec #11332

merged 2 commits into from
Mar 8, 2022

Conversation

julienrbrt
Copy link
Member

Description

Closes: #11128

sdk.Dec was using maxBitLen internally in some places, it has been changed to use maxDecBitLen.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez requested a review from tac0turtle March 8, 2022 16:06
@tac0turtle tac0turtle merged commit 3d3cf25 into cosmos:master Mar 8, 2022
mergify bot pushed a commit that referenced this pull request Mar 8, 2022
@julienrbrt
Use correct bit length constant for sdk.Dec (#11332)
279a1e8 
Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit 3d3cf25)

# Conflicts:
#	go.sum
@mergify mergify bot mentioned this pull request Mar 8, 2022
Merged
@julienrbrt julienrbrt deleted the fix-sdk-dec branch March 9, 2022 06:39
tac0turtle added a commit that referenced this pull request Mar 9, 2022
@mergify @julienrbrt @tac0turtle
fix(types): use correct bit length constant for sdk.Dec (backport #11332
11bda92 
) (#11335)

* Use correct bit length constant for sdk.Dec (#11332)

Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit 3d3cf25)

# Conflicts:
#	go.sum

* fix conflicts

Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
halibobo1205 added a commit to halibobo1205/java-tron that referenced this pull request Jun 16, 2022
@halibobo1205
fix(dec): fix error.
b1096c3 
   1. cosmos/cosmos-sdk#11332
   2. cosmos/cosmos-sdk#12229
   3. cosmos/cosmos-sdk#11772
@halibobo1205 halibobo1205 mentioned this pull request Jun 17, 2022
Merged
JimLarson pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Jul 7, 2022
@mergify @julienrbrt
@tac0turtle @JimLarson
fix(types): use correct bit length constant for sdk.Dec (backport cos…
63771a1 
…mos#11332) (cosmos#11335)

* Use correct bit length constant for sdk.Dec (cosmos#11332)

Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit 3d3cf25)

# Conflicts:
#	go.sum

* fix conflicts

Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
randy75828 pushed a commit to Switcheo/cosmos-sdk that referenced this pull request Aug 10, 2022
@mergify @julienrbrt
@tac0turtle @randy75828
fix(types): use correct bit length constant for sdk.Dec (backport cos…
075a463 
…mos#11332) (cosmos#11335)

* Use correct bit length constant for sdk.Dec (cosmos#11332)

Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit 3d3cf25)

# Conflicts:
#	go.sum

* fix conflicts

Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
randy75828 pushed a commit to Switcheo/cosmos-sdk that referenced this pull request Aug 10, 2022
@mergify @julienrbrt
@tac0turtle @randy75828
fix(types): use correct bit length constant for sdk.Dec (backport cos…
8890d70 
…mos#11332) (cosmos#11335)

* Use correct bit length constant for sdk.Dec (cosmos#11332)

Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit 3d3cf25)

# Conflicts:
#	go.sum

* fix conflicts

Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@aaronc aaronc Awaiting requested review from aaronc

Assignees
No one assigned
Labels
C:Types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use correct bit length constant for sdk.Dec
3 participants
@julienrbrt @alexanderbez @tac0turtle