-
Couldn't load subscription status.
- Fork 4.1k
chore: generate all proto files with gogo for compatibility #11121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| // go_package_prefix: | ||
| // override: | ||
| // buf.build/cosmos/cosmos-sdk: github.com/cosmos/cosmos-sdk/types/apicompat | ||
| package apicompat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is the best name. I also thought of calling it gogocompat but that isn't great either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fine since it won't be here long
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about api_gogo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. I would prefer to rename apicompat.
| // go_package_prefix: | ||
| // override: | ||
| // buf.build/cosmos/cosmos-sdk: github.com/cosmos/cosmos-sdk/types/apicompat | ||
| package apicompat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about api_gogo?
|
I actually realize this won't actually solve the problem. And we don't want more gogo types generated now |
|
The fix that worked for us in regen is to add this to the gogo protoc options: The issue with this PR is that if you use buf managed mode to set the go package to be The real fixes are either the |
Description
We ran into an issue trying to use orm options in packages which still are using gogo for msg and query servers. Because the orm proto files use buf managed mode and don't set
go_package, an invalid go path gets generated and there's a build error for the gogo .pb.go files. Even if we set thego_packageto the API module, this could sometimes fail because you can't reference pulsar generated code from gogo generated code.So this PR generated those types in
github.com/cosmos/cosmos-sdk/types/apicompatallows you to target these types from gogo using go package override with buf managed mode.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change