chore: crypto/xsalsa20symmetric: remove dependency on tendermint core #11027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The xsalsa20symmetric package is otherwise unused in Tendermint Core. Move the dependency to a subpackage of crypto and update the imports. No functional changes.
creachadair
force-pushed
the
mjf/salsa-dep
branch
from
2b992d6 to
398576d
Compare
creachadair
changed the title
Closed
4 tasks
creachadair
pushed a commit
to tendermint/tendermint
that referenced
this pull request
Jan 25, 2022
This package has no uses within Tendermint core. PR cosmos/cosmos-sdk#11027 replaces the use in the Cosmos SDK. A follow-up to #7689 and #7690.
tac0turtle
approved these changes
Jan 25, 2022
I'll be glad to, but I'm not clear what section it belongs in. It's not a feature, not a breaking change, not a bug fix, not a deprecation. Edit: I added it under "bug fixes" as being the least-unlike what this is. 🙂 If you think it's better elsewhere, just let me know. |
creachadair
pushed a commit
to tendermint/tendermint
that referenced
this pull request
Jan 26, 2022
This package has no uses within Tendermint core. PR cosmos/cosmos-sdk#11027 replaces the use in the Cosmos SDK. A follow-up to #7689 and #7690.
creachadair
pushed a commit
to tendermint/tendermint
that referenced
this pull request
Jan 26, 2022
This package has no uses within Tendermint core. PR cosmos/cosmos-sdk#11027 replaces the use in the Cosmos SDK. A follow-up to #7689 and #7690.
creachadair
pushed a commit
to tendermint/tendermint
that referenced
this pull request
Jan 26, 2022
This package has no uses within Tendermint core. PR cosmos/cosmos-sdk#11027 replaces the use in the Cosmos SDK. A follow-up to #7689 and #7690.
creachadair
pushed a commit
to tendermint/tendermint
that referenced
this pull request
Jan 26, 2022
This package has no uses within Tendermint core. PR cosmos/cosmos-sdk#11027 replaces the use in the Cosmos SDK. A follow-up to #7689 and #7690.
evan-forbes
pushed a commit
to celestiaorg/celestia-core
that referenced
this pull request
Feb 2, 2022
This package has no uses within Tendermint core. PR cosmos/cosmos-sdk#11027 replaces the use in the Cosmos SDK. A follow-up to #7689 and #7690.
evan-forbes
pushed a commit
to celestiaorg/cosmos-sdk
that referenced
this pull request
Feb 13, 2022
…cosmos#11027) The xsalsa20symmetric package is otherwise unused in Tendermint Core. Move the dependency to a subpackage of crypto and update the imports. No functional changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xsalsa20symmetric package is otherwise unused in Tendermint Core.
Move the dependency to a subpackage of crypto and update the imports.
No functional changes.