Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: tx result don't report block gas used as tx gas used #10833

Merged
merged 3 commits into from
Jan 5, 2022
Merged

fix!: tx result don't report block gas used as tx gas used #10833

merged 3 commits into from
Jan 5, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Dec 23, 2021

Description

Closes: #10832
Solution: Return empty GasInfo.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@yihuang yihuang changed the title tx result report block gas used as tx gas used tx result don't report block gas used as tx gas used Dec 23, 2021
alexanderbez
alexanderbez reviewed Dec 23, 2021
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be addressed via a backport PR? Is this specific to the release 0.45.x only?

@yihuang
Copy link
Collaborator Author

yihuang commented Dec 23, 2021 •
edited
Loading

Should this not be addressed via a backport PR? Is this specific to the release 0.45.x only?

It's for all the versions before master, 0.45,0.44,etc.
Master has refactored the tx handlers, thus don't have this issue.

@yihuang
Copy link
Collaborator Author

yihuang commented Dec 27, 2021

Can you also backport this to the older versions, particularly 0.44.x.

@ValarDragon
Copy link
Contributor

ValarDragon commented Jan 1, 2022 •
edited
Loading

Isn't this a protocol breaking change? Gas fields are serialized into headers, and IIRC tx gas usage is merkelized in the results right?

@alexanderbez
Copy link
Contributor

Isn't this a protocol breaking change? Gas fields are serialized into headers, and IIRC tx gas usage is merkelized in the results right?

@marbar3778 could you confirm re TM headers?

@yihuang
tx result report block gas used as tx gas used
ec3cf6b 
Closes: cosmos#10832
Solution: Return empty GasInfo.
@yihuang
Copy link
Collaborator Author

yihuang commented Jan 3, 2022

Isn't this a protocol breaking change? Gas fields are serialized into headers, and IIRC tx gas usage is merkelized in the results right?

I think so, at least it changes tx results which is part of the block header?

@ValarDragon
Copy link
Contributor

Ok, so this can't get backported to v0.44.x then. Can still get into v0.45 since thats not been cut yet

Change looks good to me for SDK v0.45.0, should not get backported further tho

amaury1093
amaury1093 approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CHANGELOG.md Outdated Show resolved Hide resolved
@amaury1093 amaury1093 changed the title tx result don't report block gas used as tx gas used fix!: tx result don't report block gas used as tx gas used Jan 5, 2022
@amaury1093 amaury1093 added this to the v0.45.0 milestone Jan 5, 2022
@amaury1093 amaury1093 merged commit 6d44d71 into cosmos:release/v0.45.x Jan 5, 2022
@yihuang yihuang deleted the release/v0.45.x branch January 6, 2022 01:38
@yihuang yihuang mentioned this pull request Jan 18, 2022
Closed
4 tasks
@faddat faddat mentioned this pull request Feb 28, 2022
Closed
8 tasks
JimLarson pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Jul 7, 2022
@yihuang @amaury1093 @JimLarson
fix!: tx result don't report block gas used as tx gas used (cosmos#10833
1aa8c20 
)

* tx result report block gas used as tx gas used

Closes: cosmos#10832
Solution: Return empty GasInfo.

* Update CHANGELOG.md

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Eengineer1 pushed a commit to cheqd/cosmos-sdk that referenced this pull request Aug 26, 2022
@yihuang @amaury1093 @Eengineer1
fix!: tx result don't report block gas used as tx gas used (cosmos#10833
746d80f 
)

* tx result report block gas used as tx gas used

Closes: cosmos#10832
Solution: Return empty GasInfo.

* Update CHANGELOG.md

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@yihuang @amaury1093 @JeancarloBarrios
fix!: tx result don't report block gas used as tx gas used (cosmos#10833
a4fe669 
)

* tx result report block gas used as tx gas used

Closes: cosmos#10832
Solution: Return empty GasInfo.

* Update CHANGELOG.md

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@fedekunze fedekunze fedekunze approved these changes

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.45.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yihuang @ValarDragon @alexanderbez @amaury1093 @fedekunze