Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create query context with requested block height #10827

Merged
merged 6 commits into from
Jan 4, 2022
Merged

fix: create query context with requested block height #10827

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
38c113e
create query context with block height
yun-yeo Dec 22, 2021
74917ef
Merge branch 'master' into create-query-context-with-block-height
yun-yeo Dec 22, 2021
52e362f
changelog
yun-yeo Dec 22, 2021
c042279
Merge branch 'master' into create-query-context-with-block-height
yun-yeo Dec 23, 2021
16d5aaa
Merge remote-tracking branch 'upstream/master' into create-query-cont…
yun-yeo Jan 4, 2022
6c7e98b
Merge branch 'create-query-context-with-block-height' of https://gith…
yun-yeo Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Bug Fixes

* [\#10827](https://github.com/cosmos/cosmos-sdk/pull/10827) Create query `Context` with requested block height
* [\#10414](https://github.com/cosmos/cosmos-sdk/pull/10414) Use `sdk.GetConfig().GetFullBIP44Path()` instead `sdk.FullFundraiserPath` to generate key
* (rosetta) [\#10340](https://github.com/cosmos/cosmos-sdk/pull/10340) Use `GenesisChunked(ctx)` instead `Genesis(ctx)` to get genesis block height
* [#10180](https://github.com/cosmos/cosmos-sdk/issues/10180) Documentation: make references to Cosmos SDK consistent
Expand Down
2 changes: 1 addition & 1 deletion baseapp/abci.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@ func (app *BaseApp) createQueryContext(height int64, prove bool) (sdk.Context, e
// branch the commit-multistore for safety
ctx := sdk.NewContext(
cacheMS, app.checkState.ctx.BlockHeader(), true, app.logger,
).WithMinGasPrices(app.minGasPrices)
).WithMinGasPrices(app.minGasPrices).WithBlockHeight(height)

return ctx, nil
}
Expand Down
5 changes: 3 additions & 2 deletions client/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,9 @@ func sdkErrorToGRPCError(resp abci.ResponseQuery) error {
// or an error if the query fails.
func (ctx Context) query(path string, key tmbytes.HexBytes) ([]byte, int64, error) {
resp, err := ctx.queryABCI(abci.RequestQuery{
Path: path,
Data: key,
Path: path,
Data: key,
Height: ctx.Height,
Copy link
Contributor Author

@yun-yeo yun-yeo Dec 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is to keep convention with grpc query

cosmos-sdk/client/grpc_query.go

Lines 75 to 79 in b67c4b3

abciReq := abci.RequestQuery{
Path: method,
Data: reqBz,
Height: ctx.Height,
}

})
if err != nil {
return nil, 0, err
Expand Down