Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: standalone errors go.mod #10779

Merged
merged 16 commits into from
Dec 17, 2021
Prev Previous commit
Next Next commit
cleanup
  • Loading branch information
aaronc committed Dec 14, 2021
commit dc4f7fa9a0c96fe18cc8b68b7cd3424e058b13c2
6 changes: 3 additions & 3 deletions errors/abci_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ func (s *abciTestSuite) TestABCInfo() {
wantCode: 1,
wantSpace: UndefinedCodespace,
},
// This is hard to testCodespace because of attached stacktrace. This
// case is tested in an another testCodespace.
// This is hard to test because of attached stacktrace. This
// case is tested in an another test.
//"wrapped stdlib is a full message in debug mode": {
// err: Wrap(io.EOF, "cannot read file"),
// debug: true,
Expand Down Expand Up @@ -219,7 +219,7 @@ func (s *abciTestSuite) TestABCIInfoSerializeErr() {
"single error": {
src: myErrDecode,
debug: false,
exp: "testCodespace: tx parse error",
exp: "test: tx parse error",
},
"second error": {
src: myErrAddr,
Expand Down
18 changes: 9 additions & 9 deletions errors/errors_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -168,35 +168,35 @@ func (s *errorsTestSuite) TestWrappedIs() {
}

func (s *errorsTestSuite) TestWrappedIsMultiple() {
var errTest = errors.New("testCodespace error")
var errTest2 = errors.New("testCodespace error 2")
var errTest = errors.New("test error")
var errTest2 = errors.New("test error 2")
err := Wrap(errTest2, Wrap(errTest, "some random description").Error())
s.Require().True(stdlib.Is(err, errTest2))
}

func (s *errorsTestSuite) TestWrappedIsFail() {
var errTest = errors.New("testCodespace error")
var errTest2 = errors.New("testCodespace error 2")
var errTest = errors.New("test error")
var errTest2 = errors.New("test error 2")
err := Wrap(errTest2, Wrap(errTest, "some random description").Error())
s.Require().False(stdlib.Is(err, errTest))
}

func (s *errorsTestSuite) TestWrappedUnwrap() {
var errTest = errors.New("testCodespace error")
var errTest = errors.New("test error")
err := Wrap(errTest, "some random description")
s.Require().Equal(errTest, stdlib.Unwrap(err))
}

func (s *errorsTestSuite) TestWrappedUnwrapMultiple() {
var errTest = errors.New("testCodespace error")
var errTest2 = errors.New("testCodespace error 2")
var errTest = errors.New("test error")
var errTest2 = errors.New("test error 2")
err := Wrap(errTest2, Wrap(errTest, "some random description").Error())
s.Require().Equal(errTest2, stdlib.Unwrap(err))
}

func (s *errorsTestSuite) TestWrappedUnwrapFail() {
var errTest = errors.New("testCodespace error")
var errTest2 = errors.New("testCodespace error 2")
var errTest = errors.New("test error")
var errTest2 = errors.New("test error 2")
err := Wrap(errTest2, Wrap(errTest, "some random description").Error())
s.Require().NotEqual(errTest, stdlib.Unwrap(err))
}
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ require (
github.com/cosmos/btcutil v1.0.4
github.com/cosmos/cosmos-proto v0.0.0-20211123144845-528f5002c9f8
github.com/cosmos/cosmos-sdk/db v0.0.0
github.com/cosmos/cosmos-sdk/x/group v0.0.0-00010101000000-000000000000
github.com/cosmos/cosmos-sdk/errors v0.0.0
github.com/cosmos/cosmos-sdk/x/group v0.0.0-00010101000000-000000000000
github.com/cosmos/go-bip39 v1.0.0
github.com/cosmos/iavl v0.17.3
github.com/cosmos/ledger-cosmos-go v0.11.1
Expand Down