chore: v0.45.0 Release Notes

[amaury1093]

Description

Closes: #10656

Pending on:

• fix: revert tx when block gas limit exceeded (backport: #10770) #10814

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[amaury1093]

The 3 pending pieces are all backportable. I prefer to merge and release ASAP, and figure out those pieces later. Thoughts @robert-zaremba ?

[tomtau]

@AmauryM also #10770

[tomtau]

As this issue may also affect e.g. CosmWasm: #10769 FYI @ethanfrey

[amaury1093]

I was ready to release this today. If we include #10770, then it'll need another round of QA. At regen we'll be off from this Friday, which means 0.45 will be out in Jan.

Happy to delay limited 0.45 if that's okay with everyone.

[ethanfrey]

I see no tests in #10770 and hard to see the implications.

Currently (without the patch), if I make a contract that, says, does an infinite loop and pay 100 million gas, while the block limit is 50 million, this will:

1. Run for 100 million gas, then hit out of gas, aborting the DeliverTx with a panic
2. In (txh recoveryTxHandler) DeliverTx it will then try to charge 100 million gas to a 50 million gas meter, causing another panic
3. What happens to the node?

This panic will abort all state writes in this transaction, and it will end up as an error over the abci interface (probably internal / code id = 1). That is fine.

Also, if you had 3 more transactions in the block after this one, what happens? They all should abort before running (as 0 gas left).

Personally, I am happy to have the 0.45 out this week unless the bug fix is truly critical. The whole block gas thing is a bit confusing to me in general (that we allow way too many tx in the block, then error when running them)

[tomtau]

@ethanfrey

This panic will abort all state writes in this transaction, and it will end up as an error over the abci interface (probably internal / code id = 1).

The trouble is that only the latter part happens, i.e. the state changes from that tx are persisted, but an error is returned (and no events are emitted). See #10769 (comment)

[ethanfrey]

@ethanfrey

This panic will abort all state writes in this transaction, and it will end up as an error over the abci interface (probably internal / code id = 1).

The trouble is that only the latter part happens, i.e. the state changes from that tx are persisted, but an error is returned (and no events are emitted). See #10769 (comment)

Thanks for the link. I understand it. That is very undesirable behaviour. Not sure if it is exploitable, but it is quite an annoying bug and I wouldn't expect this to happen.

[tomtau]

@AmauryM also #10770

the version backported to 0.45: #10814

[robert-zaremba]

pre-approving