Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tx with generate-only and offline shouldn't use chain id #10710

Merged
merged 12 commits into from
Dec 10, 2021
Prev Previous commit
Next Next commit
wip tests
  • Loading branch information
likhita-809 committed Dec 9, 2021
commit 3bd11f4cecf2394adec516df48e283f19cde5a80
4 changes: 3 additions & 1 deletion x/bank/client/testutil/suite.go
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ func (s *IntegrationTestSuite) TestNewSendTxCmd() {
fmt.Sprintf("--%s=true", flags.FlagOffline),
fmt.Sprintf("--%s=true", flags.FlagGenerateOnly),
},
false, 0, &sdk.TxResponse{},
true, 0, &sdk.TxResponse{},
},
{
"not enough fees",
Expand Down Expand Up @@ -482,6 +482,8 @@ func (s *IntegrationTestSuite) TestNewSendTxCmd() {

s.Require().NoError(clientCtx.Codec.UnmarshalJSON(bz.Bytes(), tc.respType), bz.String())
txResp := tc.respType.(*sdk.TxResponse)
fmt.Println("----------")
fmt.Println(tc.expectedCode, txResp.Code)
s.Require().Equal(tc.expectedCode, txResp.Code)
}
})
Expand Down