fix(cli): Allow max 1 DIRECT signer per tx #10683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
commented
Dec 6, 2021
| var prevSignatures []signing.SignatureV2 | ||
| if !overwriteSig { | ||
| prevSignatures, err = txBuilder.GetTx().GetSignaturesV2() | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } | ||
| if err := txBuilder.SetSignatures(sig); err != nil { | ||
| // Overwrite or append signer infos. |
There was a problem hiding this comment.
the old behavior was always overwriting signer info.
Now with the new behavior, when overwriteSig == false, we append signer infos.
amaury1093
commented
Dec 6, 2021
…-sdk into am/fix-check-signers
amaury1093
commented
Dec 6, 2021
amaury1093
requested review from
sahith-narahari,
robert-zaremba and
atheeshp
alexanderbez
reviewed
Dec 6, 2021
…-sdk into am/fix-check-signers
alexanderbez
approved these changes
Dec 6, 2021
atheeshp
approved these changes
Dec 6, 2021
blewater
pushed a commit
to e-money/cosmos-sdk
that referenced
this pull request
Dec 8, 2021
* fix(cli): Allow max 1 DIRECT signer per tx * Use sdkerrors * Update client/tx/tx_test.go * add more test * cl * Fix test * Update x/auth/client/testutil/suite.go * Address nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Be slightly less strict in a multi-signer TX:
Note: this only changes behavior in the CLI. In the antehandlers, we always allow any number of signers to be DIRECT.
This PR is to allow using transaction tips in the CLI.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change