Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bug when updating allowance inside AllowedMsgAllowance #10564

Merged
merged 16 commits into from
Jan 5, 2022
Merged

fix: fix bug when updating allowance inside AllowedMsgAllowance #10564

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
02c8e13
fix: update allowance inside AllowedMsgAllowance
0Tech Nov 17, 2021
408f75c
move the log entry into state-machine breaking section
0Tech Dec 20, 2021
4568717
remove redundant func
0Tech Dec 20, 2021
52eed35
use a primitive msg for the test case
0Tech Dec 20, 2021
143c5d9
remove hardcoded strings
0Tech Dec 20, 2021
cb8c84e
remove the noise
0Tech Dec 20, 2021
4206827
Merge branch 'master' into fix/feegrant_allowedmsg
amaury1093 Jan 3, 2022
de4745d
remove the unused field
0Tech Jan 4, 2022
092d219
fix newgrant into loadedgrant and add comments
0Tech Jan 4, 2022
0ad23de
Update x/feegrant/filtered_fee_test.go
0Tech Jan 4, 2022
8a556a6
add SetAllowance() method to AllowedMsgAllowance
0Tech Jan 4, 2022
67a7064
fix comment
0Tech Jan 4, 2022
999dcdd
Update CHANGELOG.md
0Tech Jan 4, 2022
6008d98
Merge branch 'master' into fix/feegrant_allowedmsg
amaury1093 Jan 4, 2022
bf6645b
Merge branch 'master' into fix/feegrant_allowedmsg
0Tech Jan 5, 2022
6e84e7a
Merge branch 'master' into fix/feegrant_allowedmsg
atheeshp Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix newgrant into loadedgrant and add comments
  • Loading branch information
@0Tech
0Tech committed Jan 4, 2022
commit 092d219f5e16343af36d04e426920fc8f21efab3
10 changes: 8 additions & 2 deletions x/feegrant/filtered_fee_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,13 +159,19 @@ func TestFilteredFeeValidAllow(t *testing.T) {

require.Equal(t, tc.remove, removed)
if !removed {
// save the new grant
// mimic save & load process (#10564)
// the cached allowance was correct even before the fix,
// however, the saved value was not.
// so we need this to catch the bug.

// create a new updated grant
newGrant, err := feegrant.NewGrant(
sdk.AccAddress(grant.Granter),
sdk.AccAddress(grant.Grantee),
allowance)
require.NoError(t, err)

// save the grant
cdc := simapp.MakeTestEncodingConfig().Codec
bz, err := cdc.Marshal(&newGrant)
require.NoError(t, err)
Expand All @@ -175,7 +181,7 @@ func TestFilteredFeeValidAllow(t *testing.T) {
err = cdc.Unmarshal(bz, &loadedGrant)
require.NoError(t, err)

newAllowance, err := newGrant.GetGrant()
newAllowance, err := loadedGrant.GetGrant()
require.NoError(t, err)
feeAllowance, err := newAllowance.(*feegrant.AllowedMsgAllowance).GetAllowance()
require.NoError(t, err)
Expand Down